PolyculeConnect/polycule-connect
4
0
Fork 0
Code Issues Pull requests 1 Releases Packages Wiki Activity Actions

feat #31: add mock connector #2

Merged
faercol merged 1 commit from add-mock-connector into main 2023-10-21 20:16:05 +00:00
Conversation 0 Commits 1 Files changed 2 +39 -2
chapoline commented 2023-10-21 19:37:24 +00:00
Owner
Copy link
No description provided.
chapoline added 1 commit 2023-10-21 19:37:25 +00:00
feat: #31
All checks were successful
continuous-integration/drone/push Build is passing
Details
7a77d6f44a
chapoline force-pushed add-mock-connector from 7a77d6f44a to ddb3fd3e17 2023-10-21 19:38:01 +00:00 Compare
chapoline force-pushed add-mock-connector from ddb3fd3e17 to b573e58961 2023-10-21 19:39:56 +00:00 Compare
chapoline changed title from feat: #31 to feat #31: add mock connector 2023-10-21 19:40:15 +00:00
faercol requested changes 2023-10-21 20:02:30 +00:00
polyculeconnect/connector/refuse_all.go Outdated
@ -0,0 +20,4 @@
return "", fmt.Errorf("You shouldn't use this function")
}
func (m *RefuseAllConnector) HandleCallback(s connector.Scopes, r *http.Request) (identity connector.Identity, err error) {
faercol commented 2023-10-21 19:59:50 +00:00
Owner
Copy link

C'est une petite convention de code en Go, mais les messages d'erreurs doivent normalement commencer par une minuscule, du coup "you shouldn't use this function"

C'est une petite convention de code en Go, mais les messages d'erreurs doivent normalement commencer par une minuscule, du coup "you shouldn't use this function"
faercol marked this conversation as resolved
polyculeconnect/main.go Outdated
@ -64,0 +70,4 @@
Type: "refuseAll",
Config: nil,
}); err != nil {
logger.L.Errorf("Failed to add connector for backend RefuseAll to stage: %s", err)
faercol commented 2023-10-21 20:01:31 +00:00
Owner
Copy link

err c'est l'objet. Ici comme on veut le message d'erreur, c'est err.Error() qu'il faut mettre dans le message de log

err c'est l'objet. Ici comme on veut le message d'erreur, c'est `err.Error()` qu'il faut mettre dans le message de log
chapoline commented 2023-10-21 20:03:54 +00:00
Author
Owner
Copy link

J'ai copié collé ton code juste en dessous :D

J'ai copié collé ton code juste en dessous :D
👀 1
faercol commented 2023-10-21 20:05:41 +00:00
Owner
Copy link

bah du coup t'as gagné une ligne de plus à corriger 😇

~~bah du coup t'as gagné une ligne de plus à corriger 😇~~
faercol marked this conversation as resolved
chapoline added 1 commit 2023-10-21 20:05:11 +00:00
syntax
All checks were successful
continuous-integration/drone/push Build is passing
Details
02370002aa
chapoline force-pushed add-mock-connector from 02370002aa to bfd4fbe75b 2023-10-21 20:12:06 +00:00 Compare
chapoline force-pushed add-mock-connector from bfd4fbe75b to 8e2b9b859a 2023-10-21 20:13:24 +00:00 Compare
faercol approved these changes 2023-10-21 20:14:00 +00:00
faercol merged commit 8e2b9b859a into main 2023-10-21 20:16:05 +00:00
faercol deleted branch add-mock-connector 2023-10-21 20:16:05 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
faercol
Labels
Clear labels
  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: PolyculeConnect/polycule-connect#2
No description provided.
Delete branch "add-mock-connector"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?