PolyculeConnect/polycule-connect
4
0
Fork 0
Code Issues Pull requests Releases Packages 1 Wiki Activity Actions

feat #4: add storage config in config file #3

Merged
chapoline merged 1 commit from add-database-backend into main 2023-10-22 12:07:49 +00:00
Conversation 0 Commits 1 Files changed 2 +57 -11
chapoline commented 2023-10-21 21:52:54 +00:00
Owner
Copy link
No description provided.
chapoline added 1 commit 2023-10-21 21:52:56 +00:00
feat #4: add storage config in config file
All checks were successful
continuous-integration/drone/push Build is passing
Details
bdd7522455
chapoline force-pushed add-database-backend from bdd7522455 to a6011106d5 2023-10-21 22:01:18 +00:00 Compare
faercol requested changes 2023-10-22 11:34:18 +00:00
polyculeconnect/config/config.go Outdated
@ -54,6 +54,19 @@ type OpenConnectConfig struct {
Issuer string `json:"issuer"`
}
type StorageConfigConfig struct {
faercol commented 2023-10-22 11:29:23 +00:00
Owner
Copy link

pourquoi pas appeler ça juste StorageConfig? Y'a pas de dépendances dans le code je crois ?

pourquoi pas appeler ça juste `StorageConfig`? Y'a pas de dépendances dans le code je crois ?
faercol marked this conversation as resolved
polyculeconnect/config/config.go Outdated
@ -66,1 +79,4 @@
} `json:"server"`
Storage struct {
StorageType string `json:"type"`
StorageConfig *StorageConfigConfig `json:"config"`
faercol commented 2023-10-22 11:30:45 +00:00
Owner
Copy link

Je l'aurais juste appelé config, pas besoin de plus, et ça évite les répétitions

Storage struct {
  Type string `json:"type"`
  Config *StorageConfig `json:"config"`
}
Je l'aurais juste appelé config, pas besoin de plus, et ça évite les répétitions ```go Storage struct { Type string `json:"type"` Config *StorageConfig `json:"config"` } ```
faercol marked this conversation as resolved
polyculeconnect/main.go Outdated
@ -47,12 +47,22 @@ func main() {
logger.Init(conf.LogLevel)
logger.L.Infof("Initialized logger with level %v", conf.LogLevel)
var storageType storage.Storage
faercol commented 2023-10-22 11:34:11 +00:00
Owner
Copy link

En vrai vu qu'on va commencer à ajouter des backends ici, ça serait ptetre pertinent d'ajouter une fonction séparée pour initialiser le storage, ça permet d'éviter de trop alourdir la fonction main

En vrai vu qu'on va commencer à ajouter des backends ici, ça serait ptetre pertinent d'ajouter une fonction séparée pour initialiser le `storage`, ça permet d'éviter de trop alourdir la fonction `main`
faercol marked this conversation as resolved
polyculeconnect/main.go Outdated
@ -49,1 +49,4 @@
var storageType storage.Storage
switch conf.StorageType {
case "memory":
faercol commented 2023-10-22 11:32:44 +00:00
Owner
Copy link

En vrai ça me parait un bon cas d'usage pour une enum. C'est un peu plus lourd à définir, mais ça permettra de typer ce switch de façon plus précise (même si contrairement à Rust n'as pas de vérification d'exhaustivité)

En vrai ça me parait un bon cas d'usage pour une enum. C'est un peu plus lourd à définir, mais ça permettra de typer ce switch de façon plus précise (même si contrairement à Rust n'as pas de vérification d'exhaustivité)
faercol marked this conversation as resolved
chapoline force-pushed add-database-backend from a6011106d5 to d9c2fcd61a 2023-10-22 11:45:10 +00:00 Compare
chapoline force-pushed add-database-backend from d9c2fcd61a to 75a6b87671 2023-10-22 11:45:58 +00:00 Compare
chapoline force-pushed add-database-backend from 75a6b87671 to 9a5c3c4b08 2023-10-22 11:52:19 +00:00 Compare
chapoline force-pushed add-database-backend from 9a5c3c4b08 to ffc217a0d5 2023-10-22 11:54:14 +00:00 Compare
faercol approved these changes 2023-10-22 11:55:29 +00:00
chapoline added 1 commit 2023-10-22 11:55:51 +00:00
Merge branch 'main' into add-database-backend
Some checks failed
ci/woodpecker/push/woodpecker Pipeline failed
Details
ci/woodpecker/pr/woodpecker Pipeline failed
Details
6222f5fdd9
chapoline force-pushed add-database-backend from 6222f5fdd9 to ffc217a0d5 2023-10-22 11:56:20 +00:00 Compare
chapoline force-pushed add-database-backend from ffc217a0d5 to ccb417ad6a 2023-10-22 11:56:33 +00:00 Compare
chapoline merged commit ccb417ad6a into main 2023-10-22 12:07:49 +00:00
chapoline deleted branch add-database-backend 2023-10-22 12:07:49 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
faercol
Labels
Clear labels
  
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: PolyculeConnect/polycule-connect#3
No description provided.
Delete branch "add-database-backend"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?